Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up pre-commit on github actions #312

Merged
merged 6 commits into from Apr 27, 2024
Merged

Conversation

Mikejmnez
Copy link
Collaborator

The following Pull Request:

@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Apr 24, 2024

Hmm. Two things going on:

  1. tests with macOs fail with the following error:
 Error: The version '3.9' with architecture 'arm64' was not found for macOS 14.4.1.

This is being reported since yesterday in here actions/setup-python#850. It looks like the issue is due to

macos-latest now uses M1 runners (macos-14-arm64) and 3.9 and earlier aren't available there: #696 (comment)
To fix, you can use one of the options at python/peps#3763, or stick to macos-12 or macos-13 (but you get some nice speedups using M1 where available).

  1. pre-commit is failing when running flake8 on a test file.
src/pydap/tests/dap_4_access/dap4_access_test.py:73:47: E226 missing whitespace around arithmetic operator

I noticed that pre-commit is running python 3.12, whereas no other action is running that version of python. It is possible the error is due to that. Indeed the issue was E226 on newer version of python.

I will investigate 1) tomorrow.

@Mikejmnez
Copy link
Collaborator Author

woohoo!
I had to remove python 3.9 from macos-latest from github actions because the runners on "macos-latest" are all M1. To run tests with python 3.9 on mac-os we'd have to define a separate runs-on: macos-13 yaml file.

@Mikejmnez Mikejmnez changed the title set up Pre commit set up pre-commit on github actions Apr 24, 2024
@Mikejmnez
Copy link
Collaborator Author

@jgallagher59701 This is ready for review. As you can see pre-commit is now running on GH actions starting on this PR.

@jgallagher59701
Copy link
Member

Yes, this looks ready to merge. Thanks!

@jgallagher59701 jgallagher59701 self-requested a review April 27, 2024 00:08
Copy link
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge! Thanks.

@Mikejmnez Mikejmnez merged commit 5674d1c into pydap:master Apr 27, 2024
8 checks passed
@Mikejmnez Mikejmnez deleted the pre-commit branch April 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants