Implement deprecated field in json schema #9298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9298 will not alter performanceComparing Summary
|
|
Please review |
sydney-runkle
approved these changes
Apr 30, 2024
Comment on lines
+1448
to
+1450
| if hasattr(cls, '__deprecated__'): | ||
| json_schema['deprecated'] = True | ||
|
|
There was a problem hiding this comment.
Just one thought here - we probably want to check if cls.__deprecated__ is True or a str, right? You can imagine a case where someone sets __deprecated__ to False on a model and this would lead to unexpected behavior. We maybe also want to check for None.
sydney-runkle
requested changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Reflect model depreciation in json schema
Related issue number
Related to #8922
Checklist
Selected Reviewer: @Kludex