Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run ruff check explicitly #9294

Merged
merged 1 commit into from Apr 28, 2024
Merged

Conversation

idan22moral
Copy link
Contributor

Change Summary

Running ruff check <path> is both clearer and more future-proof, since ruff <path> is deprecated in newer versions of Ruff.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Running `ruff check <path>` is both clearer and more future-proof, since `ruff <path>` is deprecated in newer versions of Ruff.
Copy link

codspeed-hq bot commented Apr 20, 2024

CodSpeed Performance Report

Merging #9294 will not alter performance

Comparing idan22moral:ruff-check (3f9f061) with main (77b0e1c)

Summary

✅ 13 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Apr 22, 2024
@sydney-runkle sydney-runkle enabled auto-merge (squash) April 22, 2024 13:34
@idan22moral
Copy link
Contributor Author

I've no idea what causes the seg fault in the ubuntu pypy3.10 test, it seems unrelated.

@sydney-runkle what am I missing?

@sydney-runkle
Copy link
Member

@idan22moral,

Yeah, it shouldn't be related 😢 I've never had that check fail so many times after re-runs. Trying again now!

@sydney-runkle sydney-runkle merged commit 04d4501 into pydantic:main Apr 28, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants