Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a round_to setting for float validator #9283

Closed
wants to merge 1 commit into from

Conversation

yfalomir
Copy link

Change Summary

Add a round_to setting to the float validator.
This PR is preliminary

Related issue number

"fix #8903

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Apr 19, 2024

CodSpeed Performance Report

Merging #9283 will not alter performance

Comparing yfalomir:add-a-round-float-validator (92fa385) with main (6322b24)

Summary

✅ 13 untouched benchmarks

@yfalomir
Copy link
Author

@sydney-runkle is it the kind of changes you expected for #9283? If so I'll add tests and make the PR ready for review.

@sydney-runkle
Copy link
Member

Closing based on #8903 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a round_float validator
2 participants