-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced exclude and include support for dict, json and copy #648
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
888bff7
Add advanced exclude support for dict, json and copy
Bobronium a5b41f1
Add advanced exclude support for dict, json and copy
Bobronium 927d0b9
Add advanced include support, add more tests, improve code style
Bobronium c418bba
Merge remote-tracking branch 'origin/advanced-exclude' into advanced-…
Bobronium ecfe729
Merge branch 'master' into advanced-exclude
Bobronium 3d20122
Merge branch 'master' into advanced-exclude
Bobronium 72a68d2
Merge branch 'advanced-exclude' of https://github.com/MrMrRobat/pydan…
Bobronium 14c4491
Add more tests for ValueItems
Bobronium 30613db
Removed update arg check in _calculate_keys for return None
Bobronium 6306d61
Merge branch 'master' into advanced-exclude
Bobronium 4349700
Fix formatting, remove duplicate imports
Bobronium 65fa6a8
Add # pragma: no cover to 'if TYPE_CHECKING:' block
Bobronium b244dda
tweaks and coverage
samuelcolvin 60b9fd1
fix history
samuelcolvin b8bc131
Merge branch 'master' into advanced-exclude
samuelcolvin c890daf
Add docs
Bobronium 66a009f
tweak docs
samuelcolvin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? maybe better to have a
typing ignore
comment on a few lines?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be on every line we call this method, so I thought having decorator would be better. But yeah, I can replace it with
# type: ignore
if you wishThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no that's. Sounds like I need to look at this more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MyPy throws error here because we use
and
operator onexclude=value_items and value_items.for_value(k)
So it thinks that potentially we can pass an instance of
ValueItems
itseld, but sincebool(ValueItems())
always will be equivalent forTrue
, it will never happen, so I guess we absolutely ok here.