Support extracting attributes from the parent namespace #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
allow-nested-attributes
branch
from
41eee03
to
1782ede
Compare
samuelcolvin
force-pushed
the
allow-nested-attributes
branch
from
5514c35
to
ab1d08a
Compare
hramezani
reviewed
Nov 8, 2022
|
might need #4735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on workaround for problems with python type hints namespaces, see #2678.
I'm not yet sure if this is a good idea, it's still confusing since intermediate parent namespaces are ignored.
Still this is an interesting idea.
Will need to be rebased to main once #4516 is merged.