Allow dicts to have both patternProperties and additionalProperties #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for `patternProperties` was introduced in pydantic#332, but that logic unfortunately made `patternProperties` and `additionalProperties` mutually exclusive. JSON Schema supports their combination: https://json-schema.org/understanding-json-schema/reference/object.html#additional-properties This prevented well-typed code generation for dictionaries that use regex-constrained string keys.
jparise
force-pushed
the
dict-properties-v2
branch
from
dd28872
to
c959517
Compare
|
This patch is for the |
|
All this logic will be rewritten for V2, so we can't accept this. #4516 will be merged pretty soon, then we can start working on schema for V2. Possibly we could accept this as a bug fix for v1, please create a new PR we'll review. |
Understood. I opened this PR for completeness after I opened #4641 for v1.
Cool. I'm primarily interested in fixing this in v1 (#4641) and then helping to guard against a regression in v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
patternPropertieswas introduced in #332, but that logic unfortunately madepatternPropertiesandadditionalPropertiesmutually exclusive. JSON Schema supports their combination:https://json-schema.org/understanding-json-schema/reference/object.html#additional-properties
This prevented well-typed code generation for dictionaries that use regex-constrained string keys.