Fix duplicate calls to __set_name__ for non-private attributes in BaseModel.__new__
#4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
|
Ok, good catch. I'm afk, but I'll review this and revert the other pr when I'm back. |
changes/4410-tlambert03.md
Outdated
| @@ -0,0 +1 @@ | |||
| Fix duplicate calls to `__set_name__` for non-private attributes in `BaseModel.__new__`. Add more tests. | |||
There was a problem hiding this comment.
This file can be removed, if anything, update the change from #4407.
You'll need to add "skip change file check" to the PR body.
There was a problem hiding this comment.
ok, all set this time for real 😂
sorry for the 2-step PR!
pydantic-hooky
bot
assigned tlambert03 and unassigned hramezani, samuelcolvin and PrettyWood
|
LGTM, @tlambert03 are you happy for this to be merged? (Just double checking 😆) |
🥴 yes! this time for realz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
My apologies @samuelcolvin, as I was working on adding the test you requested in #4407 (comment), I found a bug in my implementation, which is that
__set_name__was now getting called twice for public attributes (i.e. anything innew_namespace), and only once for private attributes. I didn't notice the auto-merge in time :)This PR fixes that, adds a test that
__set_name__is called only once both for regularobjectsubclasses as well asModelPrivateAttrs, and adds the test requested above to make sure the bound method works (for regular objects... privateAttrs likely won't work for this pattern, as commented in the test)skip change file check
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)