Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make SecretStr hashable #4399

Merged
merged 4 commits into from Aug 19, 2022
Merged

feat: Make SecretStr hashable #4399

merged 4 commits into from Aug 19, 2022

Conversation

chbndrhnns
Copy link
Contributor

@chbndrhnns chbndrhnns commented Aug 19, 2022 •
edited

Change Summary

Makes SecretStr hashable, cf. #4387

Related issue number

fix #4387

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@chbndrhnns chbndrhnns marked this pull request as ready for review August 19, 2022 07:22
@chbndrhnns
Copy link
Contributor Author

please review

hramezani
hramezani reviewed Aug 19, 2022
View reviewed changes
tests/test_types.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

please update

@chbndrhnns @hramezani
test: Assert that the hash of SecretStr is an integer value
bc5079d 
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@chbndrhnns
Copy link
Contributor Author

Do I need another please review here? :)

samuelcolvin
samuelcolvin reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

Please update.

pydantic/types.py Outdated Show resolved Hide resolved
@pydantic-hooky pydantic-hooky bot assigned chbndrhnns and unassigned hramezani and samuelcolvin Aug 19, 2022
@chbndrhnns
Copy link
Contributor Author

Please review

@samuelcolvin samuelcolvin enabled auto-merge (squash) August 19, 2022 09:03
@samuelcolvin
Copy link
Member

Great, thanks so much.

@samuelcolvin samuelcolvin merged commit ba58f94 into pydantic:master Aug 19, 2022
@chbndrhnns chbndrhnns deleted the hashable-secret-str branch August 19, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani left review comments

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees

@hramezani hramezani

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hashable SecretStr
4 participants
@chbndrhnns @hramezani @samuelcolvin @PrettyWood