fix: strictbytes-max-length #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
PrettyWood
requested changes
Aug 16, 2022
| u: StrictBytes = Field(..., max_length=5) | ||
|
|
||
| with pytest.raises(ValidationError, match='byte type expected'): | ||
| Model(u=123) |
There was a problem hiding this comment.
can you add a test with a byte (to make strictness pass) with
- short length to raise ValidationError
- long length to pass
?
There was a problem hiding this comment.
Done, What do you think?
pydantic-hooky
bot
assigned JeanArhancet and unassigned hramezani, samuelcolvin and PrettyWood
|
please review |
pydantic-hooky
bot
assigned hramezani, PrettyWood and samuelcolvin and unassigned JeanArhancet
hramezani
reviewed
Aug 16, 2022
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
samuelcolvin
approved these changes
Aug 16, 2022
PrettyWood
approved these changes
Aug 16, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
fix #4380
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)