New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dataclass containing Any
#4356
fix dataclass containing Any
#4356
Conversation
81462c2
to
e90e882
Compare
please review |
e90e882
to
88a6ea2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, but I wonder if we can reduce the size of the change somewhat?
please update.
88a6ea2
to
9038a76
Compare
9038a76
to
579a1ea
Compare
This is a fix since V1.9, so really needs to be included before we release v1.10. NoticeSee twitter 🐦, I've you'd like this to be included in V1.10, please fix it and request a review TODAY. Or if you need this in V1.10 but don't have time to complete it (or aren't the author), please comment here and on #4324. |
@samuelcolvin all outstanding conversations are resolved, unless there's something i'm missing? i think it's ready to merge |
Okay, I'll look. In future, best if you can say "please review" so the label changes and reviewers get assigned. I basically only look at PRs with the "ready for review" label. |
my bad, i didn't realize i had to comment it again after making changes, i assumed clicking "re-request review" would've done it |
Totally understandable. We might be able to somehow extend hooky to detect "re-request review" if there's a webhook for it. But it doesn't work at present. |
This is great, thanks so much. |
Change Summary
remove
Any
types that contributed to usages of thedataclass
decorator causing mypy errors when using thedisallow-any-expr
ruleRelated issue number
fixes #4355
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)