fix "extra fields not permitted" error when dataclass with Extra.forbid is validated multiple times
#4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachHead
force-pushed
the
fix_extra_fields_not_permitted
branch
2 times, most recently
from
1419225
to
5e6720d
Compare
…bid` is validated multiple times
DetachHead
force-pushed
the
fix_extra_fields_not_permitted
branch
from
5e6720d
to
06f7de3
Compare
|
please review |
16 tasks
|
Sorry, I didn't realise the comment on the commit in the other repo would close this. 🙈 |
|
Thanks so much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
if a
dataclassgets validated multiple times by_dataclass_validate_valuesand hasExtra.forbidin its config, it will fail validation as__pydantic_initialised__is considered to be an invalid extra property.i figured the safest fix for this (and any potential other similar issues) was to check whether the class has already been validated before validating it again.
Related issue number
fixes #4343
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)