New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch Exceptions in smart_deepcopy #4187
Catch Exceptions in smart_deepcopy #4187
Conversation
please review @samuelcolvin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one thing to change.
please update. |
LGTM, @coneybeare is this complete? |
@samuelcolvin I believe it is, yes |
great, thanks so much. In future, it's safest to use the magic comment "please review" to assign the PR to me and make sure I know the PR needs my attention. |
Change Summary
This PR comes from an issue where a
sqlalchemy
column definition was raising whennot obj
was called insmart_deepcopy
. Whether or not the raise is warranted is a question forsqlalchemy
, but catching the error here and falling back todeepcopy
on seems to be a decent approach as a raise of this nature prevents application import and load.Related issue number
Closes #4184
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)