Fix issue with ClassVar parsing #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
uriyyo
force-pushed
the
fix-issue-3401
branch
3 times, most recently
from
1efd532
to
0535148
Compare
uriyyo
force-pushed
the
fix-issue-3401
branch
from
0535148
to
3f97854
Compare
dusty-phillips
approved these changes
Nov 15, 2021
3 tasks
zekiblue
reviewed
Nov 18, 2021
PrettyWood
approved these changes
Nov 18, 2021
|
Thank you so much |
|
Is there a release planned to get this on pypi? |
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Dec 4, 2021
* Fix issue with ClassVar parsing * Fix lint error * Simplify test * Fix condition and test
PrettyWood
pushed a commit
to PrettyWood/pydantic
that referenced
this pull request
Dec 6, 2021
* Fix issue with ClassVar parsing * Fix lint error * Simplify test * Fix condition and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
Fixes #3401
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)