Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested env #3159
Nested env #3159
Changes from 10 commits
46eea4b
730c039
3518f5e
b9ed167
6c457ce
ae9592e
88aae14
1994a92
581906b
0ab431a
63ffab3
4a83110
67d5680
c97138a
5e9b229
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this approach works.
If you change the order of env variables in your test below, the result changes. E.g. put
env.set('top__sub__v5', '5')
first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the right logic, because this variable should be overwritten by the next one
env.set('top', '{"v1": "1", "v2": "2", "sub": {"v5": "xx"}}')
But thank you for pointing on this. Double checked all combinations and yes there was a bug. Redesigned this method and test a bit according to this bug and logic from my answer on your comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you need this here? Also not sure why we're catching and ignoring
TypeError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed about the
TypeError
we process only env values here, so there are only sting values.We need this piece because env_val can be a json string. And there could be a situation when you want to mix both approaches of defining nested models:
So the correct behaviour in my mind was that we should merge those variables into one, instead of overwriting.