Check for collections.abc.Mapping instead of dict when converting a…
#3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pydantic field to a dict.
facebook-github-bot
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Aug 19, 2021
…of dict. Summary: We want to add a `frozendict` class to `shape`, which is a pydantic model. However, when pydantic gets the attributes for a model for serialization, it only makes copies of dict objects, not dict-like objects like `Mapping`. We should treat these as dicts and make dict-like copies so we update the check to `collections.abc.Mapping`. We can revert this diff once the public facing pull request pydantic/pydantic#3101 is merged upstream, and our depedency is updated. Reviewed By: snarkmaster Differential Revision: D30378486 fbshipit-source-id: 185fc483d594f0ecf1d2fcaca39e7d719b936a7c
|
please review |
|
Any chance this (partially) fixes #3122 ( |
|
If I have class Model(BaseModel):
a: MyCustomMap[str, int]I expect my value in the dict representation to be a instance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pydantic field to a dict.
Change Summary
We would like to be able use a custom immutable
frozendictin fields as pydantic and havedict()continue to work as expected. So we should use a more generic type likecollections.abc.Mappinginstead of dict to make sure that we still convert it to a dict.Related issue number
N/A
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
please review