Fix bug when mypy plugin fail on construct method call #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
# Conflicts: # tests/mypy/modules/plugin_success.py
|
@PrettyWood Could you review again? |
Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Oct 7, 2021
* Fix bug when mypy plugin fail on construct method call * Update type annotation for __config__ field * Remove type ignore * Update changes/2753-uriyyo.md Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
mypyplugin bugFix bug when
mypyplugin fails onconstructmethod call forBaseSettingsderived classes.Related issue number
Closes #2753
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)