fix: generate a valid name in schema for Enum classes
#2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2582 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5109 5102 -7
Branches 1050 1047 -3
=========================================
- Hits 5109 5102 -7
Continue to review full report at Codecov.
|
PrettyWood
force-pushed
the
fix/schema-generic-enum
branch
from
ea34bc3
to
f334c4b
Compare
This reverts commit f334c4b.
samuelcolvin
added a commit
that referenced
this pull request
May 11, 2021
* fix: generate a valid name in schema for `Enum` classes * test: add schema with generic enum * (erase me): just to check fastapi tests * Revert "(erase me): just to check fastapi tests" This reverts commit f334c4b. * fix linting 😴 Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
A regression has been introduced in 1.8 since we now use
display_as_typefor the name of the model anddisplay_as_typehandlesEnumweirdly.IMO the special case for
Enumis not useful anymore since they are properly handled now both in code and in schema but let's see what the CI says!Related issue number
closes #2575
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)