Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generic subclass support #2549

Merged
merged 9 commits into from
Dec 5, 2021
Merged

Improve generic subclass support #2549

merged 9 commits into from
Dec 5, 2021

Commits on May 17, 2021

  1. Derive concrete subclasses for parameterised generics

    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    181b912 View commit details
    Browse the repository at this point in the history

  2. Resolve type issues

    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    a121bb7 View commit details
    Browse the repository at this point in the history

  3. Add negative assertions to generic subclass tests

    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    3c7ffed View commit details
    Browse the repository at this point in the history

  4. Remove incorrect subclassing of partial. 

    The type was incorrectly being picked up for this style of subclassing,
and it can be regardless inferred through cls.
    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ca49da7 View commit details
    Browse the repository at this point in the history

  5. Apply feedback: 

    * Improve parameterisation explanation
* fix typos
* Alias Parameterisation type
    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    2677824 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    * start docstring with newline.
* Use None as default over empty tuple.

Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
    @diabolo-dan @samuelcolvin
    diabolo-dan and samuelcolvin committed May 17, 2021
    Configuration menu
    Copy the full SHA
    358efb5 View commit details
    Browse the repository at this point in the history

  7. Combine _assigned_parameters cases in __paramaterized_bases__ of gene… 

    …rics
    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    5505ec4 View commit details
    Browse the repository at this point in the history

  8. Add description for the _assigned_parameters variable.

    @diabolo-dan
    diabolo-dan committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b4a8841 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Merge branch 'master' into diabolo-dan-improve_generic_subclass_support

    @samuelcolvin
    samuelcolvin committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    193ee06 View commit details
    Browse the repository at this point in the history