fix: support arbitrary types with custom __eq__
and Annotated
with python 3.9
#2502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When the default value is an instance of a class with a custom
__eq__
, it can fail as shown in the written test.But the question is "why did we switch from an identity check against
Undefined
to an equality check againstUndefined
ANDEllipsis
?`The answer lies here
https://github.com/samuelcolvin/pydantic/blob/62bb2ad4921016df51abf3922c3fe51113b08939/tests/test_annotated.py#L121-L130
To support this, a check on
Ellipsis
has been added, which is wrong IMO.It has been done because the default value of the
Field
is not the same once it has been validated (Undefined
becomesRequired
akaEllipsis
)2 solutions:
original_default
and use this one for the check againstUndefined
Undefined
I went with solution 2 as it doesn't seem to have any impact
Related issue number
closes #2483
closes #2639
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)