Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mypy): fix custom Path and UUID related types #2420

Merged
merged 4 commits into from Mar 2, 2021
Merged

fix(mypy): fix custom Path and UUID related types #2420

merged 4 commits into from Mar 2, 2021

Commits on Feb 27, 2021

  1. add tests that should pass 

    But we have those errors

226: error: Item "str" of "Union[UUID, str]" has no attribute "hex"  [union-attr]
227: error: Item "str" of "Union[UUID, str]" has no attribute "hex"  [union-attr]
228: error: Item "str" of "Union[Path, str]" has no attribute "absolute"  [union-attr]
229: error: Item "str" of "Union[Path, str]" has no attribute "absolute"  [union-attr]
230: error: Item "str" of "Union[Path, str]" has no attribute "absolute"  [union-attr]
231: error: Item "str" of "Union[Path, str]" has no attribute "absolute"  [union-attr]
    @PrettyWood
    PrettyWood committed Feb 27, 2021
    Copy the full SHA
    ef5e312 View commit details
    Browse the repository at this point in the history

  2. fix: right types should be valid

    @PrettyWood
    PrettyWood committed Feb 27, 2021
    Copy the full SHA
    75bf574 View commit details
    Browse the repository at this point in the history

  3. remove new useless type: ignore

    @PrettyWood
    PrettyWood committed Feb 27, 2021
    Copy the full SHA
    983e986 View commit details
    Browse the repository at this point in the history

  4. docs: add change file

    @PrettyWood
    PrettyWood committed Feb 27, 2021
    Copy the full SHA
    8af052d View commit details
    Browse the repository at this point in the history