Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "resolve_annotations" more lenient, allowing for missing modules #2366

Merged
merged 2 commits into from Feb 15, 2021

Conversation

samuelcolvin
Copy link
Member

Make resolve_annotations more lenient, allowing for missing modules

Related issue number

fix #2363

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #2366 (0274937) into master (cc3010c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2366   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          23       23           
  Lines        4496     4500    +4     
  Branches      909      909           
=======================================
+ Hits         4495     4499    +4     
  Misses          1        1           
Impacted Files Coverage Δ
pydantic/typing.py 99.42% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3010c...0274937. Read the comment docs.

@samuelcolvin samuelcolvin merged commit fc18f8e into master Feb 15, 2021
@samuelcolvin samuelcolvin deleted the improve-resolve_annotations branch February 15, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with BaseModel if used with importlib
1 participant