Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): fix typing-extensions version #2361

Merged
merged 1 commit into from Feb 13, 2021

Conversation

PrettyWood
Copy link
Member

@PrettyWood PrettyWood commented Feb 13, 2021

Change Summary

typing-extensions has been bumped to 3.4.7.3 in #2216 to have a good DefaultDict for python 3.8 and less.
But now when running make install and make test, the TypedDict related tests fail because the installed
version is 3.4.7, which does not have TypedDict backport.
This fixes this

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #2361 (d995d45) into master (13928e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2361   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          23       23           
  Lines        4496     4496           
  Branches      909      909           
=======================================
  Hits         4495     4495           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13928e5...d995d45. Read the comment docs.

@samuelcolvin samuelcolvin merged commit cc3010c into pydantic:master Feb 13, 2021
@samuelcolvin
Copy link
Member

🙏 thank you.

@PrettyWood PrettyWood deleted the bump-typing-extensions branch February 13, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants