Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support empty tuple type #2319

Merged
merged 1 commit into from Feb 13, 2021

Conversation

PrettyWood
Copy link
Member

@PrettyWood PrettyWood commented Feb 4, 2021

Change Summary

Currently we don't support Tuple[()]. Now we do

Related issue number

closes #2318

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #2319 (7530e77) into master (13a5c7d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2319   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         4199      4201    +2     
  Branches       854       855    +1     
=========================================
+ Hits          4199      4201    +2     
Impacted Files Coverage Δ
pydantic/fields.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a5c7d...7530e77. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 9ca8fe8 into pydantic:master Feb 13, 2021
@PrettyWood PrettyWood deleted the fix/support-empty-tuple branch February 13, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty tuple type
2 participants