Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate and parse nested models properly with default_factory #1712

Merged
merged 4 commits into from Jul 15, 2020
Merged

fix: validate and parse nested models properly with default_factory #1712

merged 4 commits into from Jul 15, 2020

Commits on Jul 12, 2020

  1. fix: validate nested models with default_factory 

    PR pydantic#1504 introduced a regression by bypassing `populate_validators()`,
which would skip the validation of children in nested models
with `default_factory`

closes pydantic#1710
    @PrettyWood
    PrettyWood committed Jul 12, 2020
    Copy the full SHA
    458dc13 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. test: add example of nested models parsing with default_factory 

    closes pydantic#1717
    @PrettyWood
    PrettyWood committed Jul 13, 2020
    Copy the full SHA
    16e489b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. add testcase from pydantic#1722

    @samuelcolvin
    samuelcolvin committed Jul 15, 2020
    Copy the full SHA
    e2c3158 View commit details
    Browse the repository at this point in the history

  2. bodge for benchmarks

    @samuelcolvin
    samuelcolvin committed Jul 15, 2020
    Copy the full SHA
    e43a72b View commit details
    Browse the repository at this point in the history