Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private attributes support #1679

Merged
merged 26 commits into from
Oct 26, 2020
Merged

Add private attributes support #1679

merged 26 commits into from
Oct 26, 2020

Commits on Jul 2, 2020

  1. Add private attributes support

    @Bobronium
    Bobronium committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    5964240 View commit details
    Browse the repository at this point in the history

  2. Add more blank lines in example

    @Bobronium
    Bobronium committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    d783caf View commit details
    Browse the repository at this point in the history

  3. Add changes file

    @Bobronium
    Bobronium committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    d4dabc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Merge branch 'master' into add-private-attributes

    @Bobronium
    Bobronium committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    c182678 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Update docs/usage/models.md 

    Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
    @Bobronium @samuelcolvin
    Bobronium and samuelcolvin committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    1c7256a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Merge branch 'master' into add-private-attributes 

    # Conflicts:
#	pydantic/main.py
#	pydantic/utils.py
#	tests/test_utils.py
    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    ef640ff View commit details
    Browse the repository at this point in the history

  2. fix after bad merge

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    3868ad3 View commit details
    Browse the repository at this point in the history

  3. Add PrivateAttr, Config.underscore_attrs_are_private

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    d60de4c View commit details
    Browse the repository at this point in the history

  4. remove unrelated change in utils.py

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    9096f63 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into add-private-attributes 

    # Conflicts:
#	pydantic/main.py
#	pydantic/schema.py
#	tests/test_construction.py
    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    90576d2 View commit details
    Browse the repository at this point in the history

  6. add # noqa: C901 (ignore complexity) to __setattr__ 

    (see comment in PR)
    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    a701b3e View commit details
    Browse the repository at this point in the history

  7. add annotation to Config.underscore_attrs_are_private 

    Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
    @Bobronium @samuelcolvin
    Bobronium and samuelcolvin committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    33e3f28 View commit details
    Browse the repository at this point in the history

  8. use sunder names

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    dcfee02 View commit details
    Browse the repository at this point in the history

  9. mention underscore_attrs_are_private in model_config.md

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    063ba48 View commit details
    Browse the repository at this point in the history

  10. add comment about default factory

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    1333ffb View commit details
    Browse the repository at this point in the history

  11. fix comment

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    788d24b View commit details
    Browse the repository at this point in the history

  12. fix comment

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    dedb465 View commit details
    Browse the repository at this point in the history

  13. clarify that both dunder and sunder names might be used

    @Bobronium
    Bobronium committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    6ea1a1f View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. tweak docs and name

    @samuelcolvin
    samuelcolvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    08d6f5d View commit details
    Browse the repository at this point in the history

  2. _set_default_private_attributes -> _init_private_attributes 

    Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
    @Bobronium @samuelcolvin
    Bobronium and samuelcolvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    60ebda2 View commit details
    Browse the repository at this point in the history

  3. use new name _init_private_attributes

    @samuelcolvin
    samuelcolvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    2689d36 View commit details
    Browse the repository at this point in the history

  4. move tests

    @Bobronium @samuelcolvin
    Bobronium authored and samuelcolvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    afa3fb9 View commit details
    Browse the repository at this point in the history

  5. copy private attributes in BaseModel.copy()

    @Bobronium
    Bobronium committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    47464ba View commit details
    Browse the repository at this point in the history

  6. add test for default and default_factory used together

    @Bobronium
    Bobronium committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    7fe179a View commit details
    Browse the repository at this point in the history

  7. fix linting

    @Bobronium
    Bobronium committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    2090ba4 View commit details
    Browse the repository at this point in the history

  8. more tests, default_factory kw only

    @samuelcolvin
    samuelcolvin committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    104d600 View commit details
    Browse the repository at this point in the history