Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url port check #1678

Merged
merged 5 commits into from Jul 3, 2020
Merged

Url port check #1678

merged 5 commits into from Jul 3, 2020

Conversation

flapili
Copy link
Contributor

@flapili flapili commented Jul 2, 2020

Change Summary

add a port check to AnyUrl

Related issue number

fix #1654

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #1678 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1678   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3806      3812    +6     
  Branches       757       758    +1     
=========================================
+ Hits          3806      3812    +6     
Impacted Files Coverage Δ
pydantic/errors.py 100.00% <100.00%> (ø)
pydantic/networks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f219501...6bb1174. Read the comment docs.

pydantic/networks.py Outdated Show resolved Hide resolved
flapili and others added 3 commits July 2, 2020 20:57
fix typo

Co-authored-by: PrettyWood <em.jolibois@gmail.com>
@samuelcolvin samuelcolvin merged commit dac6764 into pydantic:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url type port limit not checked
3 participants