Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RedisDsn.user_required = True #1658

Merged
merged 2 commits into from Jun 26, 2020
Merged

Conversation

samuelcolvin
Copy link
Member

Related issue number

replace #1302, fix #1275

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1658 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master    #1658      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           21       21              
  Lines         3795     3794       -1     
  Branches       753      753              
===========================================
- Hits          3795     3792       -3     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
pydantic/networks.py 99.21% <ø> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d531f...52b6e0b. Read the comment docs.

@samuelcolvin samuelcolvin merged commit d122b1d into master Jun 26, 2020
@samuelcolvin samuelcolvin deleted the RedisDsn-user-not-required branch June 26, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisDSN with out username
1 participant