Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): allow custom encoding for dotenv files #1620

Merged
merged 1 commit into from Jun 11, 2020

Conversation

PrettyWood
Copy link
Member

Change Summary

Allow to customize encoding for dotenv files

Related issue number

closes #1615

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #1620 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1620   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3796      3798    +2     
  Branches       752       752           
=========================================
+ Hits          3796      3798    +2     
Impacted Files Coverage Δ
pydantic/env_settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329b1d3...fc63b5c. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 0cee311 into pydantic:master Jun 11, 2020
@samuelcolvin
Copy link
Member

great, thank you.

@PrettyWood PrettyWood deleted the feat/dotenv-encoding branch June 11, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add encoding to read_env_file()
2 participants