Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datetime parser to support negative timestamps #1605

Merged
merged 1 commit into from Jun 27, 2020
Merged

Update datetime parser to support negative timestamps #1605

merged 1 commit into from Jun 27, 2020

Conversation

mlbiche
Copy link
Contributor

@mlbiche mlbiche commented Jun 5, 2020

Change Summary

Update datetime parser to support negative timestamps. Negative timestamps corresponds to dates before 1970/1/1.

Related issue number

Close #1600

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

- Negative timestamps corresponds to dates before 1970/1/1
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1605 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3796      3796           
  Branches       752       752           
=========================================
  Hits          3796      3796           
Impacted Files Coverage Δ
pydantic/datetime_parse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e82689...0c6124d. Read the comment docs.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll merge when I've been through other PRs.

@samuelcolvin samuelcolvin merged commit 113921c into pydantic:master Jun 27, 2020
@samuelcolvin
Copy link
Member

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript negative timestamp are not supported
2 participants