fix(schema): use right type check for __modify_schema__ #1562
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As @therefromhere explains in #1552,
__modify_schema__
was called for the schema field but also for the list schema becausefield.type_
would be the same in both cases.Changed it to
field.outer_type_
Related issue number
fix #1552
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)