Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1541 UUID bytes support for 16 byte strings / BINARY(16) #1542

Merged
merged 3 commits into from May 31, 2020

Conversation

shawnwall
Copy link
Contributor

@shawnwall shawnwall commented May 20, 2020

Change Summary

  • Updated UUID validation to take into account 16 byte strings per python documentation
  • Created new test for this byte string type

Related issue number

Fixes #1541

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see [changes/README.md]

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #1542 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1542   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3772      3775    +3     
  Branches       749       749           
=========================================
+ Hits          3772      3775    +3     
Impacted Files Coverage Δ
pydantic/validators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eeb225...2cf70ad. Read the comment docs.

@StephenBrown2
Copy link
Contributor

This looks good to me. @samuelcolvin what are your thoughts on the documentation bit?

@samuelcolvin
Copy link
Member

This is great, thank you. I'll merge it as soon as I've run through the older PRs.

@samuelcolvin samuelcolvin merged commit 4f9e77d into pydantic:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID validation fails when provided with 16-byte string
3 participants