New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NameEmail equality comparison #1527
Fix NameEmail equality comparison #1527
Conversation
- Introducing new test assertions for NameEmail Signed-off-by: Stephen Bunn <stephen@bunn.io>
Signed-off-by: Stephen Bunn <stephen@bunn.io>
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3761 3772 +11
Branches 748 749 +1
=========================================
+ Hits 3761 3772 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Signed-off-by: Stephen Bunn <stephen@bunn.io>
Awesome, thank you. |
Change Summary
Introducing an
__eq__
fornetworks.NameEmail
as two similar instances were not being correctly evaluated as equal.Related issue number
closes #1514
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)