Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constr regex example to include start and end lines #1400

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Update constr regex example to include start and end lines #1400

merged 1 commit into from
Apr 18, 2020

Conversation

lmcnearney
Copy link
Contributor

Change Summary

This is due to the regex using re.match() which allows for only a partial match.

Related issue number

#1396

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

This is due to the regex using `re.match()` which allows for only a partial match
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #1400 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1400   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3736      3736           
  Branches       739       739           
=========================================
  Hits          3736      3736           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8bda5...751e466. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 161a12a into pydantic:master Apr 18, 2020
@samuelcolvin
Copy link
Member

Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants