Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct name of validate_arguments in docs #1375

Merged
merged 4 commits into from
Apr 18, 2020
Merged

correct name of validate_arguments in docs #1375

merged 4 commits into from
Apr 18, 2020

Conversation

samuelcolvin
Copy link
Member

I had a brain fart while writing the docs for validate_arguments, @StephenBrown2 pointed this out in #1179 (comment).

Hopefully I've caught every one.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1375 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3723      3736   +13     
  Branches       735       739    +4     
=========================================
+ Hits          3723      3736   +13     
Impacted Files Coverage Δ
pydantic/mypy.py 100.00% <0.00%> (ø)
pydantic/types.py 100.00% <0.00%> (ø)
pydantic/utils.py 100.00% <0.00%> (ø)
pydantic/errors.py 100.00% <0.00%> (ø)
pydantic/fields.py 100.00% <0.00%> (ø)
pydantic/schema.py 100.00% <0.00%> (ø)
pydantic/validators.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaec3c9...c5f2eca. Read the comment docs.

Copy link
Contributor

@StephenBrown2 StephenBrown2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to submit a PR with these changes, including some punctuation I've noted.
Not sure about the emphasis of *pydantic* in only one place.

docs/usage/validation_decorator.md Outdated Show resolved Hide resolved
docs/usage/validation_decorator.md Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Member Author

I tried to use *pydantic* everywhere, but I've slipped a bit.

I'm go though the rest tomorrow.

samuelcolvin and others added 3 commits April 8, 2020 09:24
Co-Authored-By: Stephen Brown II <Stephen.Brown2@gmail.com>
Co-Authored-By: Stephen Brown II <Stephen.Brown2@gmail.com>
@samuelcolvin samuelcolvin merged commit ec25f60 into master Apr 18, 2020
@samuelcolvin samuelcolvin deleted the mad-typo branch April 18, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants