Use chain.from_iterable in class_validators.py (#1642)

* Use chain.from_iterable in class_validators.py * fix change Co-authored-by: Samuel Colvin <s@muelcolvin.com>
pydantic · Jun 27, 2020 · ecb54c5 · ecb54c5
1 parent 5a2d787
commit ecb54c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/changes/1642-cool-RR.txt b/changes/1642-cool-RR.txt
@@ -0,0 +1,3 @@
+Use `chain.from_iterable` in class_validators.py. This is a faster and more idiomatic way of using `itertools.chain`.
+Instead of computing all the items in the iterable and storing them in memory, they are computed one-by-one and never
+stored as a huge list. This can save on both runtime and memory space.
diff --git a/pydantic/class_validators.py b/pydantic/class_validators.py
@@ -164,11 +164,9 @@ def get_validators(self, name: str) -> Optional[Dict[str, Validator]]:
 
     def check_for_unused(self) -> None:
         unused_validators = set(
-            chain(
-                *[
-                    (v.func.__name__ for v in self.validators[f] if v.check_fields)
-                    for f in (self.validators.keys() - self.used_validators)
-                ]
+            chain.from_iterable(
+                (v.func.__name__ for v in self.validators[f] if v.check_fields)
+                for f in (self.validators.keys() - self.used_validators)
             )
         )
         if unused_validators: