Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:logging config loaded source #68

Closed
wants to merge 5 commits into from

Conversation

oslijunw
Copy link

@oslijunw oslijunw commented Jun 2, 2023

for :#63

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.81 🎉

Comparison is base (56ba90a) 94.77% compared to head (075287c) 95.58%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   94.77%   95.58%   +0.81%     
==========================================
  Files           5        5              
  Lines         306      317      +11     
  Branches       70       70              
==========================================
+ Hits          290      303      +13     
+ Misses         13       12       -1     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
pydantic_settings/main.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oslijunw
Copy link
Author

oslijunw commented Jun 2, 2023

I don't know how to fix the lint to pass the first test, I haven't changed much in the code, so can't figure out how to solve this problem with the ci process

@@ -16,6 +18,7 @@
SecretsSettingsSource,
)

log = logging.getLogger('pydantic')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pydantic.settings? I'm not sure what's the best name here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks for your reply, I will change that

@hramezani
Copy link
Member

Close as per comment here

@hramezani hramezani closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants