Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strip = true to release profile #348

Merged
merged 2 commits into from Dec 22, 2022
Merged

add strip = true to release profile #348

merged 2 commits into from Dec 22, 2022

Conversation

samuelcolvin
Copy link
Member

See pydantic/pydantic#2276 for related discussion on binary sizes for pydantic before v2.

Comparing binary sizes I get:

(env38) gitpod /workspace/pydantic-core (main) $ ls -lh dist-main/
total 1.7M
-rw-r--r-- 1 gitpod gitpod 1.5M Dec 21 14:03 pydantic_core-0.7.1-cp38-cp38-linux_x86_64.whl
-rw-r--r-- 1 gitpod gitpod 167K Dec 21 14:02 pydantic_core-0.7.1.tar.gz
(env38) gitpod /workspace/pydantic-core (main) $ ls -lh dist-strip/
total 1.2M
-rw-r--r-- 1 gitpod gitpod 1.1M Dec 21 14:05 pydantic_core-0.7.1-cp38-cp38-linux_x86_64.whl
-rw-r--r-- 1 gitpod gitpod 167K Dec 21 14:04 pydantic_core-0.7.1.tar.gz

I think that's worthwhile vs. uglier tracebacks for crashes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #348 (0601b4c) into main (883048a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files          59       59           
  Lines        6981     6981           
  Branches       47       47           
=======================================
  Hits         6781     6781           
  Misses        200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883048a...0601b4c. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 21, 2022

CodSpeed Performance Report

Merging #348 strip-on-release (0feabb5) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 65 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin samuelcolvin added the Full Build cause CI to do a full build label Dec 21, 2022
@samuelcolvin samuelcolvin merged commit 03a2adf into main Dec 22, 2022
@samuelcolvin samuelcolvin deleted the strip-on-release branch December 22, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants