Multi host URLs, other URL changes #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 97.23% 97.35% +0.12%
==========================================
Files 57 57
Lines 6514 6890 +376
Branches 45 46 +1
==========================================
+ Hits 6334 6708 +374
- Misses 179 182 +3
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
samuelcolvin
added a commit
that referenced
this pull request
Nov 9, 2022
* adding multi host urls * linting and more test cases * tweak unicode_string logic to replace range * consume leading whitespace on multihost urls * yet more test cases * improve coverage * add vulnerabilties tests * remove "host_type" from url * fix unicode positioning with multihost urls * uprev * allow default_host, default_port, default_path * fix schema vs. scheme typo * empty hosts() if no host * tweaking url public methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #324 and #317.
Reimplement multi-host URLs, see:
Todo: