bump pyo3 to 0.17.1 #236
bump pyo3 to 0.17.1 #236
Conversation
|
Will do, currently fighting with v1.10. |
cannot infer type of the type parameter `V` declared on the associated function `set_item`
the trait bound `&pyo3::PyAny: pyo3::IntoPy<pyo3::Py<PyString>>` is not satisfied
PrettyWood
force-pushed
the
pyo3-0.17.0
branch
from
9988f63
to
e3e4f3f
Compare
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 98.69% 98.65% -0.04%
==========================================
Files 48 48
Lines 5042 4992 -50
Branches 35 35
==========================================
- Hits 4976 4925 -51
- Misses 66 67 +1
Continue to review full report at Codecov.
|
|
@samuelcolvin @davidhewitt This is ready for review but I feel like this is hacky. If you have a better way of doing it I'm all ears 🙏 |
src/input/datetime.rs
Outdated
| Some(offset) => { | ||
| let tz_info = TzInfo::new(offset); | ||
| Some(Py::new(py, tz_info)?.to_object(py)) | ||
| let obj = Py::new(py, tz_info)?.to_object(py); |
There was a problem hiding this comment.
I think the following might work for these three lines:
| let obj = Py::new(py, tz_info)?.to_object(py); | |
| Some(Py::new(py, tz_info)?.to_object(py).extract(py)?) |
Will rely on type inference for .extract() to give you the &PyTzInfo.
I do think there's some missing API and documentation for PyO3 in this area, just haven't quite decided what the API should look like.
There was a problem hiding this comment.
Thank you! I first tried that but had issue with lifetime of variable since Py::new takes ownership of the pointer (hence my usage of from_borrowed_ptr instead. I fixed it in 8f09d8c
fix #214