Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent int,float,decimal -> str #212

Merged
merged 3 commits into from Aug 2, 2022
Merged

prevent int,float,decimal -> str #212

merged 3 commits into from Aug 2, 2022

Conversation

samuelcolvin
Copy link
Member

fix #150

Almost all the changes are in tests, the actual code removed is trival, wouldn't be hard to add it again if we ever did add a comparability flag, through I'm opposed to that.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #212 (38e14a1) into main (1e93886) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files          47       47              
  Lines        4948     4936      -12     
  Branches       34       34              
==========================================
- Hits         4883     4871      -12     
  Misses         65       65              
Impacted Files Coverage Δ
src/input/input_json.rs 97.51% <ø> (-0.03%) ⬇️
src/input/input_python.rs 98.45% <ø> (-0.04%) ⬇️
src/input/return_enums.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e93886...38e14a1. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 42a465a into main Aug 2, 2022
@samuelcolvin samuelcolvin deleted the remove-int-to-str branch August 2, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevent int, float and Decimal from being converted to strings
1 participant