Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intern build keys #178

Merged
merged 8 commits into from
Jul 18, 2022
Merged

Intern build keys #178

merged 8 commits into from
Jul 18, 2022

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jul 18, 2022

Based off #177 can be rebased once that's merged.

This makes building the complete benchmark model ~30% faster.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #178 (ef5856b) into main (f29eec1) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   97.58%   97.77%   +0.18%     
==========================================
  Files          45       45              
  Lines        4391     4451      +60     
  Branches       32       32              
==========================================
+ Hits         4285     4352      +67     
+ Misses        106       99       -7     
Impacted Files Coverage Δ
src/build_tools.rs 96.92% <100.00%> (+11.20%) ⬆️
src/validators/bytes.rs 96.77% <100.00%> (+0.16%) ⬆️
src/validators/date.rs 95.12% <100.00%> (+0.06%) ⬆️
src/validators/datetime.rs 96.00% <100.00%> (+0.08%) ⬆️
src/validators/dict.rs 95.69% <100.00%> (+0.04%) ⬆️
src/validators/float.rs 98.76% <100.00%> (+0.03%) ⬆️
src/validators/function.rs 96.33% <100.00%> (+0.09%) ⬆️
src/validators/int.rs 100.00% <100.00%> (ø)
src/validators/is_instance.rs 96.42% <100.00%> (ø)
src/validators/list.rs 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29eec1...ef5856b. Read the comment docs.

@samuelcolvin samuelcolvin marked this pull request as ready for review July 18, 2022 16:43
@samuelcolvin samuelcolvin merged commit 7da1a6a into main Jul 18, 2022
@samuelcolvin samuelcolvin deleted the intern-build-keys branch July 18, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant