defer to PyO3 i64 extraction to avoid implicit integer casts #1288
+13
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
changed the title
davidhewitt
commented
May 14, 2024
Comment on lines
+76
to
+78
| # Python 3.9 and below allowed truncation of float to integers in some | ||
| # cases, by not making this an error we can test for this behaviour | ||
| 'ignore:(.+)Implicit conversion to integers using __int__ is deprecated', |
There was a problem hiding this comment.
By adding this ignore it allows the deprecated behaviour on older versions, thus testing them. Without the Rust change in this PR I get test failures locally which are consistent with pydantic/pydantic#9018.
CodSpeed Performance ReportMerging #1288 will not alter performanceComparing Summary
|
|
... except it looks like PyO3 gets PyPy wrong, because PyPy didn't change on 3.10 - pypy/pypy#4949 |
davidhewitt
force-pushed
the
dh/implicit-int
branch
from
6712079
to
59af7b6
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As per PyO3/pyo3#3742, the PyO3 logic for i64 extraction has workarounds for older Python versions which allowed float -> int casts in some contexts.
Related issue number
Fixes pydantic/pydantic#9018
Checklist
pydantic-core(except for expected changes)