Stopgap measure for Python 3.13 testing: Minimal port of tests from bottle to flask #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bottle is not Python 3.13+ ready, see bottlepy/bottle#1403 In Fedora, we need pycurl to be able to use fedpkg, our tool for building Fedora packages. I plan to use this patch in Fedora temporarily until the bottle situation is resolved.
hroncok
changed the title
|
Thanks @hroncok! Any reasons this couldn't/shouldn't be merged? It seems like bottle is under-maintained these days. |
|
That's entirely up to you. I just didn't want to appear out of nowhere asking for you to switch your test web framework :) I need to stress out:
|
hroncok
commented
Apr 24, 2024
Comment on lines
113
to
+121
| @app.route('/set_cookie_invalid_utf8') | ||
| def set_cookie_invalid_utf8(): | ||
| bottle.response.set_header('Set-Cookie', '\xb3\xd2\xda\xcd\xd7=%96%A6g%9Ay%B0%A5g%A7tm%7C%95%9A') | ||
| return 'cookie set' | ||
| response = flask.Response('cookie set') | ||
| # WARNING: The original bottle test passed '\xb3\xd2\xda\xcd\xd7...' as string | ||
| # Presumably bottle encoded that as utf-8 in the response. | ||
| # Flask on the other hand encodes such strings as latin-1 (chars in == bytes out). | ||
| # In order to make the test pass I replicate the original bottle behavior by utf-8->latin1 roundtrip. | ||
| response.headers['Set-Cookie'] = '\xb3\xd2\xda\xcd\xd7=%96%A6g%9Ay%B0%A5g%A7tm%7C%95%9A'.encode('utf-8').decode('latin-1') | ||
| return response |
There was a problem hiding this comment.
Also, if this PR would be merged, perhaps we need a better look at this.
What is "invalid UTF-8" supposed to test here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bottle is not Python 3.13+ ready, see bottlepy/bottle#1403
In Fedora, we need pycurl to be able to use fedpkg, our tool for building Fedora packages.
I plan to use this patch in Fedora temporarily until the bottle situation is resolved.
I do not expect this to be merged, but I opened this PR anyway, in case you or others find it useful. With this, tests pass on Python 3.13.