Fixes #255 -- Add verification methods to the Connection object #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablosole
force-pushed
the
add_verify_to_connection
branch
from
e3a9f1a
to
91c7159
Compare
pablosole
force-pushed
the
add_verify_to_connection
branch
from
91c7159
to
b005ac0
Compare
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the methods
set_verify,set_verify_depth,get_verify_mode, andget_verify_depthto the Connection object.While Connection objects inherit these values from the Context used to create it, they can be changed afterward. This is especially useful when using SNI to require different verification flags depending on the server name (ie. require client certs in some SNIs but not on others).
Fixes #255