Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow elliptic curve keys in from_cryptography_key(). #636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow elliptic curve keys in from_cryptography_key(). #636

wants to merge 2 commits into from

Commits on Jun 10, 2017

  1. Allow elliptic curve keys in from_cryptography_key(). 

    Elliptic curve support in PKey objects still needs to be implemented.

With this change an (Certificate Transparency) SCT can be verified
against the public key of a CT-Log. CT-Logs usually are signed with an
elliptic curve digest.  The argument `cert` of the function
`verify(cert, signature, data, digest)` is just a wrapper for its `pkey`
attribute.  This attribute now can contain an ec-pubkey.  Here is an example
of this usage:
https://github.com/theno/ctutlz/blob/master/ctutlz/sct/verification.py#L29
    @theno
    theno committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    f71b806 View commit details
    Browse the repository at this point in the history

  2. Skip test_convert_from_cryptography_unsuported_type() 

    `from_cryptography()` now accepts EC Pkeys and does not raise an TypeError.
    @theno
    theno committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    6e7c49d View commit details
    Browse the repository at this point in the history