Add ssl version constants #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Dec 21, 2020
alex
approved these changes
Dec 21, 2020
|
As always, thanks for the super super quick helpful feedback! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm upgrading mitmproxy to use
SSL_CTX_set_min_proto_version(with the idea to get the changes into pyOpenSSL as well), and it turns out the version constants are not exposed at the moment. :)SSL_CTX_set_min_proto_versionlanded in #5595, see https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_min_proto_version.html for the OpenSSL docs.