Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be more verbose in the 102 deprecation notice #5505

Merged
merged 1 commit into from Oct 25, 2020
Merged

be more verbose in the 102 deprecation notice #5505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cryptography/hazmat/bindings/openssl/binding.py
View file
Open in desktop
Expand Up @@ -181,8 +181,11 @@ def _verify_openssl_version(lib):
else:
raise RuntimeError(
"You are linking against OpenSSL 1.0.2, which is no longer "
"supported by the OpenSSL project. You need to upgrade to a "
"newer version of OpenSSL."
"supported by the OpenSSL project. To use this version of "
"cryptography you need to upgrade to a newer version of "
"OpenSSL. For this version only you can also set the "
"environment variable CRYPTOGRAPHY_ALLOW_OPENSSL_102 to "
"allow OpenSSL 1.0.2."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not included this in previous OpenSSL version droppings, and instead referred people to the docs. Why now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I've fielded at least one question on StackOverflow where it turns out they broke their pip (due to the pyOpenSSL + cryptography on older pip/Python). They couldn't find the docs because we only keep them around for one version and I'd rather make it obvious how to fix it directly in the error.

)


Expand Down