Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the OpenSSL signature recovery function available from Python #5457

Closed
wants to merge 1 commit into from

Conversation

misterzed88
Copy link
Contributor

There is a sometimes a need to recover the RSA signature data in order to parse its format. This is used with non-standard signature formats. Since this is an exotic case, the support was added only at the low level through the OpenSSL lib wrapper, without high level API support in hazmat.

@reaperhulk
Copy link
Member

@misterzed88 When we don't have direct consumers in our bindings it becomes very difficult for us to maintain them effectively. If we're going to merge this without a hazmat layer API could you write a (pretty big) comment that explains the use case more thoroughly? You can put it directly above the bindings. Also, linking this PR in the comment would be good. Blame works, but only until we end up reformatting something in the future, so a URL that can point back here is also helpful.

Alternately, what does a hazmat API for this look like and how would someone document it to explain the (rare) use of it?

@misterzed88
Copy link
Contributor Author

You're right, exposing internal interfaces for external use is usually fragile. Thank you for even considering it.

Let's try to do it in the proper way. I will come back with an explanation of the use case and a proposed hazmat API for it. Then we'll see if it fits into the current API philosophy.

@reaperhulk reaperhulk mentioned this pull request Oct 3, 2020
@misterzed88
Copy link
Contributor Author

I opened a separate issue (#5495) for this requirement to solve the problem in a more generic way than this pull request.

@misterzed88 misterzed88 deleted the openssl-sign-recover branch November 17, 2020 08:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants