Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards incompatible change to DNSName #3951

Merged
merged 8 commits into from Oct 11, 2017
Merged

Backwards incompatible change to DNSName #3951

merged 8 commits into from Oct 11, 2017

Commits on Oct 10, 2017

  1. Backwards incompatible change to DNSName 

    During this release cycle we decided to officially deprecate passing
U-labels to our GeneralName constructors. At first we tried changing
this in a purely backwards compatible way but get_values_for_type made
that untenable. This PR modifies DNSName to take three different types.
U-label strings (which raises a deprecation warning), A-label strings
(the new preferred type), and bytes (which are assumed to be decodable
to unicode strings). The latter, while supported, is primarily intended
for use by our parser and allows us to return the actual encoded data in
a certificate even if it has not been properly encoded to A-label before
the certificate is created. (Of course, if the certificate contains
invalid utf8 sequences this will still fail, but let's handle one
catastrophic failure at a time).
    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    80cf093 View commit details
    Browse the repository at this point in the history

  2. coverage

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    d3b66a9 View commit details
    Browse the repository at this point in the history

  3. don't delete that asterisk from a test. it does things.

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    52457f7 View commit details
    Browse the repository at this point in the history

  4. no bytes in DNSName. Private constructor for bypassing validation

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    4b38941 View commit details
    Browse the repository at this point in the history

  5. test unicode in dnsname (yuck)

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    0eb3d67 View commit details
    Browse the repository at this point in the history

  6. fix docs

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    a5eb726 View commit details
    Browse the repository at this point in the history

  7. empty commit, you disappoint me codecov

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    31f4c48 View commit details
    Browse the repository at this point in the history

  8. CI is the worst

    @reaperhulk
    reaperhulk committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    2d1c07c View commit details
    Browse the repository at this point in the history